Fixes to Google Drive Explorer Icon script

svenkle / google-drive-add-to-explorer

293 stars 106 forks source link

Fixes to Google Drive Explorer Icon script #3

Closed shawnz closed 7 years ago

shawnz commented 7 years ago

Here I made some changes, including:

Changing the GUID to resolve a conflict with the GUID for the Google Drive 'syncing' overlay icon.
Changing the folder path to a REG_EXPAND_SZ so it is not necessary for the user to edit the file.

svenkle commented 7 years ago

Hi Shawn,

Thanks for submitting the PR. I will validate and approve it shortly.

I'm curious to know if these changes came purely from experience dealing with the Registry or did you have an additional source of documentation that lead you to optimise the files?

shawnz commented 7 years ago

I did some research over the last day or two, see primarily: https://msdn.microsoft.com/en-us/library/windows/desktop/dn889934.aspx and for documentation about REG_SZ vs REG_EXPAND_SZ see: https://msdn.microsoft.com/en-us/library/windows/desktop/ms724884(v=vs.85).aspx

I discovered the true purpose of the 81539F... GUID by searching the registry for it. You can see that it is registered at "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\ShellIconOverlayIdentifiers\ GoogleDriveSyncing".

jantienm commented 7 years ago

Hi,

I used your registry entry and it works perfectly, thanks!

The only thing that I am experiencing is that when I open an explorer window from an application (like attaching a file in an e-mail) i get an error. I wil attach it. It's in Dutch, but it says: %USERPROFILE%\Google drive not available. Make sure it is connected.

Hopefully you can solve this issue? That would be great! Thanks again for posting this workaround.

shawnz commented 7 years ago

Hi @jantienm, could you please click start, input cmd.exe /k set, hit enter and take a screenshot?

jantienm commented 7 years ago

Hi Shawn, here it is

shawnz commented 7 years ago

Have you tried rebooting since applying the patch?

jantienm commented 7 years ago

I thought I did but I'll try again

jantienm commented 7 years ago

Just rebooted but still the same problem. I did first applied the patch with the wrong userprofile path. Firstly i used: C://Google Drive. Then it didn't work and changed the path to: C:\Users\Jantien\Google Drive. Then it worked perfectly except for the issue opening a flie from an application.

shawnz commented 7 years ago

Looks like I was wrong about removal of the Wow6432Node keys, this breaks 32 bit applications.