search

svenkreiss / html5validator

Command line tool to validate HTML5 files. Great for continuous integration.
MIT License
323 stars 34 forks source link

Undocumented Validator API breaking changes in v0.2.10 #40

Closed Lucas-C closed 6 years ago

Lucas-C commented 6 years ago

Pypi latest version of this package is v0.2.10, but there is no matching tag in GitHub, nor a mention of it in the README Changelog.

Sadly this version broke my pre-commit hook using it :( Indeed, Validator.validate does not accept anymore the errors_only nor stack_size parameter.

svenkreiss commented 6 years ago

Whoops. Didn't know anyone relies on the internal API.

Some changes were necessary to support new options in vnu.jar. It is actually more general now but the interface is not that pretty. Can you check the changes proposed in #41 and provide comments if you have any?

Lucas-C commented 6 years ago

No problem. I switched my lib to the new API: https://github.com/Lucas-C/pre-commit-hooks-java/releases/tag/1.3.7 The changes seem legitimate, I don't have any thing to add.

svenkreiss commented 6 years ago

@Lucas-C just a heads up that #41 changed the internal API again. This is not on PyPI yet but will be soon.

Lucas-C commented 6 years ago

Thank you very much

Lucas-C commented 6 years ago

Just for documentation purpose, some more API changes were also made in https://github.com/svenkreiss/html5validator/commit/a42c732150fef79a4f5444bfc1920c06ea661b16