search

svenkreiss / html5validator

Command line tool to validate HTML5 files. Great for continuous integration.
MIT License
314 stars 34 forks source link

Expose --Werror vnu option #43

Closed php-coder closed 6 years ago

php-coder commented 6 years ago

In the PR #39 you exposed a couple options and also updated vnu.jar to a new version that has useful --Werror option. Could it be exposed to html5validator?

I'm surprised that it's not enabled by default...

svenkreiss commented 6 years ago

The return code of html5validator is calculated differently from vnu.jar. We have a --show-warnings option which also affects the return code. Is that what you are looking for?

php-coder commented 6 years ago

We have a --show-warnings option which also affects the return code.

Does it mean that html5validator will return 1 when only warnings encountered?

svenkreiss commented 6 years ago

Yes.

... and I realize there is no unit test for that. There should be.