search

svenkreiss / html5validator

Command line tool to validate HTML5 files. Great for continuous integration.
MIT License
314 stars 34 forks source link

Consider using --stdout option to vnu.jar #72

Closed mhansen closed 3 years ago

mhansen commented 4 years ago

Hi there, the maintainer of https://github.com/validator/validator, which this depends on, just added an option to the validator to output the HTML warnings & HTML errors to stdout, while leaving stderr free for exceptional cases (exceptions, error messages that are unrelated to the HTML).

https://github.com/validator/validator/commit/1ce0b83873c2da0c374373764efec2b1a5532e4e

You might consider switching to setting --stdout, and reading from the stdout stream rather than the stderr stream. This would save you having to filter out errors from the stream like Picked up _JAVA_OPTIONS: here: https://github.com/svenkreiss/html5validator/blob/master/html5validator/validator.py#L17.

bittner commented 4 years ago

@mhansen Could you turn your suggestion into an acitonable PR, please? This will make it more likely that your feature suggestion comes true.

svenkreiss commented 4 years ago

No, filing an issue to let us know about this nice new addition to the validator is valid. No PR necessary. Thank you @mhansen .

mhansen commented 4 years ago

I'm happy to try my hand at a pull request, just wanted to check with you first if this would be desired.

On Wed, 8 Jul 2020 at 00:37, Sven Kreiss notifications@github.com wrote:

No, filing an issue to let us know about this nice new addition to the validator is valid. No PR necessary. Thank you @mhansen https://github.com/mhansen .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/svenkreiss/html5validator/issues/72#issuecomment-654908498, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZYOISMAYOTLFSMW22M33R2MXJLANCNFSM4NZKFW5Q .

svenkreiss commented 3 years ago

Thanks for reporting. Done in #82 .