svenkreiss / html5validator

Command line tool to validate HTML5 files. Great for continuous integration.
MIT License
314 stars 34 forks source link

Fixes test with log file and adds skip option #75

Closed Cyb3r-Jak3 closed 3 years ago

Cyb3r-Jak3 commented 3 years ago

Biggest Changes

Cyb3r-Jak3 commented 3 years ago

Pypy implementation in Github Actions does not appear to be working. See https://github.com/actions/virtual-environments/issues/1716 Resolved

Cyb3r-Jak3 commented 3 years ago

@svenkreiss Would you be open to switching to GitHub Actions for the CI?

I have been messing around with it a bit and if switching there is a lot more tests that can be run such as different os and java versions. Here is an example of what it would look like: https://github.com/Cyb3r-Jak3/html5validator/actions/runs/285811420. That is testing the same python versions, with java 8-13 and ubuntu 16, 18, and 20, mac-os and windows. Allows for seeing if there are issues with different java version or OS.

Cyb3r-Jak3 commented 3 years ago

@svenkreiss I added a new option --skip to allow users to skip certain files. This was requested in the GitHub action. https://github.com/Cyb3r-Jak3/html5validator-action/issues/12.

Was not sure if you want a separate PR for it.

khusika commented 3 years ago

Is there any plan to merge this?

svenkreiss commented 3 years ago

Thanks @Cyb3r-Jak3 for the PR and @khusika for the reminder.

The moved tests are a blocker for me. I want to be able to run these tests without the full source tree.

I am also against a new command line argument but it does make a lot of sense to extend --blacklist to also remove individual files and not only directories.

Cyb3r-Jak3 commented 3 years ago

@svenkreiss Tests are back to where they were. Also, make it so the blacklist command does files and directories.

You are definitely going to want squash merge this as the config tests don't work on Windows due to the path.

Cyb3r-Jak3 commented 3 years ago

Looking through everything, I agree this got incredibly messy. I am going to close out this PR and start fresh.