search

svenkreiss / html5validator

Command line tool to validate HTML5 files. Great for continuous integration.
MIT License
314 stars 34 forks source link

[CSS] False positives #76

Closed MichaIng closed 3 years ago

MichaIng commented 3 years ago

The following false positives are thrown:

error: CSS: "text-decoration-skip-ink": Property "text-decoration-skip-ink" doesn't exist.
error: CSS: "color-adjust": Property "color-adjust" doesn't exist.
error: CSS: "overflow-anchor": Property "overflow-anchor" doesn't exist.

But those are valid CSS:

If it's an external library that is responsible for those tests, please advice where to address this to 🙂.

sideshowbarker commented 3 years ago

If it's an external library that is responsible for those tests, please advice where to address this to 🙂.

Ultimately those errors are coming from the https://github.com/w3c/css-validator code. So if possible, please raise three separate issues at https://github.com/w3c/css-validator/issues (one for each of those properties).

Also, in the meantime before support gets added to the https://github.com/w3c/css-validator code, I can add update the https://github.com/validator/validator code to suppress the errors (which will ultimately have the effect of causing https://github.com/svenkreiss/html5validator to now report them either).

MichaIng commented 3 years ago

Okay great, will report those over at W3C repo, although only overflow-anchor is missing:

I excluded them via --ignore 'text-decoration-skip-ink' 'color-adjust' 'overflow-anchor', so from my end no workaround from your side required, but many thanks for offering 🙂.

MichaIng commented 3 years ago

For the record, found another one, the relatively new aspect-ratio CSS property (not the media feature): https://github.com/w3c/css-validator/issues/287

And the totally forgotten request for supporing overflow-anchor: https://github.com/w3c/css-validator/issues/288