search

svenkreiss / html5validator

Command line tool to validate HTML5 files. Great for continuous integration.
MIT License
314 stars 34 forks source link

Fix #86 #87

Closed jamesjuett closed 3 years ago

jamesjuett commented 3 years ago

This PR fixes #86.

Since Python 3.7, os.errno is no longer available.

svenkreiss commented 3 years ago

Thanks @jamesjuett . Do you have a reference for that? It seems, in practice, os.errno still works because our tests are passing.

jamesjuett commented 3 years ago

Fair question! I've tracked down an authoritative source:

https://github.com/python/cpython/blob/main/Doc/whatsnew/3.7.rst#changes-in-the-python-api

(Near the bottom of the list, or just search for "errno".)

svenkreiss commented 3 years ago

Thanks for that reference. If you can fix the lint error (import order) then this is good to go.

jamesjuett commented 3 years ago

Ah yeah, my bad on the import ordering - fixed!

(Note on the force push...I'm on WSL and have issues with clock drift when my machine hibernates. The force push was after I realized my commit to fix the lint issue was showing up as several days ago.)

svenkreiss commented 3 years ago

Awesome. Thanks for the fix!