JackWH
commented
4 years ago @svenluijten Thanks, happy to contribute! I just pushed a few more tweaks to this branch...
- Changed dependency version constraints, as you suggested
- This one is kind of opinionated, but I noticed the package just dumps a
forge.jsonconfig file in the user's home directory:- I changed the
getFileConfig()function to prefer a hidden~/.forge.jsonfile instead - It will continue to use
~/forge.jsonif one exists for backwards-compatibility - Going forward, new calls to
forge authorizewill save a hidden file instead - I feel this is more in keeping with convention for global packages
- I changed the
- When a
.forge.jsonconfiguration file is created for the first time, a JSONkeyproperty is now being set to an empty string:- Previously, it was just an empty object being saved (
{}) - This change ensures "Unauthorized" exceptions are thrown by Guzzle, instead of a PHP fatal error
- Errors would be thrown when trying to call the Forge API before
forge authorizehas been run
- Previously, it was just an empty object being saved (
svenluijten
barryvdh
After being held up by issue #40, I've gone ahead and updated the dependencies used by this package to bring it up to date.
Here's what's changed:
composer.jsonto use version^2.0ofthemsaid/forge-sdk. Version 2.0 has some new parameters added to certain functions (see here), which I haven't accounted for inforge-cli— but the function definitions remain backwards-compatible.composer.jsonto use version^5.0ofsymfony/consoleandsymfony/process. This was necessary as the current release oflaravel/homesteadinstalls version^5.0of these packages globally, so the existing dependency version^4.0was causing conflicts that prevented installation.return 0;to everysymfony/consoleinheritedexecute()function, a new requirement following the version updates.return 0;indicates the command ran successfully, any other result should be an integer and will be returned as a process exit status to the shell.forge authorizecommand to allow for the API key to be passed in as an optional parameter. If no parameter is specified, the user will be prompted to type it in to the terminal window themselves. This change allows programmatic setup of the Forge CLI via other Artisan commands.