search

svenpaulsen / node-ts3sdk-client

TeamSpeak 3 SDK Client Addon for Node.js
30 stars 3 forks source link

Implement promises #4

Open antoine-pous opened 6 years ago

antoine-pous commented 6 years ago

Hi,

can you implement promise when the callback is not provided? Promises are really usefull :)

svenpaulsen commented 6 years ago

To be honest... I'm not familiar with the concept of promises. Can you provide a short example?

antoine-pous commented 6 years ago

You can see an implementation on my ServerQuery client here https://github.com/antoine-pous/node-teamspeak3-client

I'm not familiar with this approach to interface the SDK and nodejs, i don't know how to update the sources to improve the compiled code in ts3client.node and implement Promises and eventemitter2.

If you want you can take a look to my fork https://github.com/antoine-pous/node-ts3sdk-client/tree/typescript-tested