search

svenpeter42 / fastfilters

Old academic project for my PhD - no longer maintained by me: fast gaussian and derivative convolutional filters
MIT License
9 stars 10 forks source link

run tests on all platforms #22

Closed k-dominik closed 5 years ago

k-dominik commented 5 years ago

Just glanced over your code for some inspiration (Mondays...) and stumbled over this slightly weird test setup including this file:

https://github.com/svenpeter42/fastfilters/blob/master/tests/set_paths.py.in

and wonderful lines like:

https://github.com/svenpeter42/fastfilters/blob/715281e8ee20e15080e416b60e13e1d33984908f/tests/test_vigra_compare.py#L5

For me, going through these gymnastics seems like there is something odd going on.

Anyway, I also noticed that the tests weren't run on windows. So I added this to the conda recipe. It would probably be better, however, to find away around these exec(compile... stuff

svenpeter42 commented 5 years ago

I don't believe I ever wrote those tests. I believe that line was added by Fynn because something special was needed for windows.