search

svenstaro / glsl-language-server

Language server implementation for GLSL
MIT License
179 stars 29 forks source link

CMake system libraries option ignored #52

Open mkoncek opened 1 year ago

mkoncek commented 1 year ago

Commit e0172233d93b2e4dc307a17fa8f0ec15e43c2298 basically removed the benefits of 63b8a9ee134c533815b18d649be844ccfa654761 and acdea1050776eb2e3dcd2edd0ea6ef13cba99971. The build again link all the libraries unconditionally. I don't know if this was intentional, but I would like it reverted.

Do you want me to add a Fedora build using system libs without HTTP into your GH workflow so that you can see if it breaks with commits?

svenstaro commented 1 year ago

Uh, I'm sorry, that wasn't intended. Would you be interested in becoming a maintainer of this project? I'm unlikely to get much more work done on this.

mkoncek commented 1 year ago

Hmm, that is unfortunate. Unfortunately I am not familiar with LSP protocol and don't have time or motivation to learn it and develop this. It remains that currently this is the only LSP client that can be built and works in Fedora.

nolanderc commented 1 year ago

@mkoncek Sorry to hijack this thread, but have you tried/looked at glsl_analyzer? I'm on Fedora, and it works fine for me.

Or, if my memory serves me, you are trying to get this into the Fedora package manager, right? If so, I would be interested in figuring out what is needed to make this possible for glsl_analyzer as well.

mkoncek commented 1 year ago

It doesn't compile with the zig compiler that is currently in Fedora. Also there are currently no guidelines / macros for packaging zig packages. I don't even know whether zig does static / dynamic linking.

As of now, that project uses a pre-release version of the compiler which is not packaged. Of course that could be updated, I will check that possibility later.

nolanderc commented 1 year ago

As of now, that project uses a pre-release version of the compiler which is not packaged.

I see. Hopefully that will can change once 0.12 is released (I can now see that dnf only has 0.9.1).

I don't even know whet zig does static / dynamic linking.

I think it can do both, but in the case of glsl_analyzer we have zero dependencies, which makes it possible to build a fully static executable on Linux (it statically links musl, so it doesn't even dynamically link libc). But if linking libc is prefered, we can do that as well.