search

svenstaro / miniserve

🌟 For when you really just want to serve some files over HTTP right now!
MIT License
6.11k stars 296 forks source link

Add single click file icon to download file directly and change file … #1376

Closed chaibiq closed 7 months ago

chaibiq commented 7 months ago

Add single click file icon to download file directly and change file size text of mobile view to no-wrap. 2024-03-30 22 33 07

svenstaro commented 7 months ago

What's the reasoning behind this?

Also please fix the tests. :)

chaibiq commented 7 months ago

Hi, so sorry I can't fix what wrong in tests, I want to use the file symbol to make download process quicker with one click for image/video file. Just want to avoid the right click menu for downloading image/video file.

chaibiq commented 7 months ago

https://github.com/svenstaro/miniserve/actions/runs/8508049448 Its already passed the tests , but here seeing 1 failing, 13 successful, 2 cancelled, and 1 skipped checks. Dont know wrong in this page here.. Should I close it first ?

svenstaro commented 7 months ago

Well, do the tests work locally for you?

chaibiq commented 7 months ago

Well, do the tests work locally for you?

Yes, it's work at local windows and my GitHub master

chaibiq commented 7 months ago

I already create new PR, but just update the scss part for mobile view.

I think to close this PR.