search

svenstaro / rofi-calc

🖩 Do live calculations in rofi!
MIT License
966 stars 31 forks source link

Patches for issue #28 #31

Closed yoshimoto closed 4 years ago

yoshimoto commented 5 years ago

I wrote two patches to solve issue #28. Could you please review/merge this?

svenstaro commented 5 years ago

This seems to be quite a lot of code for basically specifying a minimum version. Now I'm not an Autotools expert but it would seem to me that perhaps we should just have the readme specify a minimum version if that means a lot less Autotools code.

Maybe you could explain the changes a bit if I misread? I can't check properly right now as I'm on mobile.

yoshimoto commented 5 years ago

Sorry for my lack of explanation.

My pull request contains the following three fixes: 1) Added version check 2) Fixed Miss-usage of AM_CFLAGS; The flags in AM_CFLAGS are not used at all. 3) Added -Werror=implicit-function-declaration

I'd like to withdraw this pull request once, and then send new pull request, which contains the above 1) only.

svenstaro commented 5 years ago

Please rebase against master. I updated our rofi version to 1.5.4.