svenstaro / upload-release-action

Upload files to a GitHub release
MIT License
626 stars 110 forks source link

Converting Pre-Release to Release #64

Open pranjal-joshi opened 2 years ago

pranjal-joshi commented 2 years ago

Hello, I have a matrix job that builds executables for multiple platforms.

I want to upload binaries to the same pre-release and then publish the release only if all matrix jobs pass the test.

Need guidance for creating a pre-release first and then publishing the same in the next job if tests are passed.

Existing workflow is here - https://github.com/pranjal-joshi/Screeni-py/blob/c2899ab1097802ee2b7c91078a4c197c98377f79/.github/workflows/workflow-build-matrix.yml#L133

shawaj commented 1 year ago

You could just do it with four separate jobs in the same action, one for each of the matrix builds and the final one for the upload release action.

And just use a needs, similar to: https://github.com/NebraLtd/hm-pyhelper/blob/ced0a994551e0a360798a19fb4d7f3620e4bd454/.github/workflows/test.yml#L49

Or maybe you could use something like this as well: https://github.com/lewagon/wait-on-check-action

svenstaro commented 1 year ago

This should be done as of #74. Please check whether that suits your needs.