search

svenstaro / upload-release-action

Upload files to a GitHub release
MIT License
626 stars 110 forks source link

Modernise the `README.md` #85

Closed ggreif closed 1 year ago

ggreif commented 1 year ago

Time is marching on, so

svenstaro commented 1 year ago

This should now all be fixed, please check.

shawaj commented 1 year ago

@ggreif do you mean that all three lines below can be removed from the readme?

          r="${r//'%'/'%25'}"                               # Multiline escape sequences for %
          r="${r//$'\n'/'%0A'}"                             # Multiline escape sequences for '\n'
          r="${r//$'\r'/'%0D'}"
ggreif commented 1 year ago

@shawaj

@ggreif do you mean that all three lines below can be removed from the readme?

          r="${r//'%'/'%25'}"                               # Multiline escape sequences for %
          r="${r//$'\n'/'%0A'}"                             # Multiline escape sequences for '\n'
          r="${r//$'\r'/'%0D'}"

Turns out you can't. I had to revert my other change. But now I have filed a PR to check whether multi-line strings arrive properly in the release. (You have to allow the CI.) I have seen it leaving %0A in the body and not converting those back to newlines (this was with @v2, I wonder if 2.4.0 behaves the same).

shawaj commented 1 year ago

@ggreif latest @v2 should be the same as v2.4.0 as it's tagged as such https://github.com/svenstaro/upload-release-action/releases/tag/v2

And

https://github.com/svenstaro/upload-release-action/releases/tag/2.4.0

But depends whether you ran that within the last 2 weeks since v2.4.0 was released

ggreif commented 1 year ago

@ggreif latest @v2 should be the same as v2.4.0 as it's tagged as such https://github.com/svenstaro/upload-release-action/releases/tag/v2

And

https://github.com/svenstaro/upload-release-action/releases/tag/v2.4.0

But depends whether you ran that within the last 2 weeks since v2.4.0 was released

I guess that should be https://github.com/svenstaro/upload-release-action/releases/tag/2.4.0

Nope, I run the action lats time in December.

shawaj commented 1 year ago

Oops yes that was a typo sorry