sventonsvn / sventon

This is sventon's final resting place.
Other
10 stars 13 forks source link

An unhandled internal application error occurs when clicking RSS feed button on a directory which contains a space, #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
If the subversion directory contains a space then the RSS subscribe URL 
contains a '%2520' . Subscribing results then in 
An unhandled internal application error has occured

Removing the 25 of %2520 gives the correct URL.

https://sventon.example.com/svn/xml/myrepo/rss/READ%2520MEs/?revision=HEAD

It seems that <space> is encoded to %20 and then % is encode to %25 which 
results then in %2520

I tried this in sventon 2.5.1 and in the svnkit verision and in the javaHL 
version.

sventon war file is deployed in tomcat6 with following connector settings:

    <Connector port="8080" protocol="HTTP/1.1"
               connectionTimeout="20000"
               URIEncoding="UTF-8"
               redirectPort="8443" />

Is this a bug and is there a known solutions or workaround?
thanx anyway.

Original issue reported on code.google.com by jesper.hammarback on 12 Oct 2011 at 8:38

GoogleCodeExporter commented 9 years ago
Hi & thanks for reporting!

You are correct - the URL is encoded twice by mistake.

Line 22 in the file "WEB-INF/jspf/pageFoot.jspf" should say:

 <s:url value="/xml/${command.name}/rss${command.path}" var="rssUrl">

instead of

 <s:url value="/xml/${command.name}/rss${command.encodedPath}" var="rssUrl">

I will fix this asap so it will be included in the next minor release.

Regards
Jesper

Original comment by jesper.hammarback on 12 Oct 2011 at 8:40

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2083.

Original comment by jesper.hammarback on 30 Oct 2011 at 7:57

GoogleCodeExporter commented 9 years ago
Fixed in revision 2083.

Original comment by jesper.hammarback on 30 Oct 2011 at 7:57