search

svenvc / ston

STON - Smalltalk Object Notation - A lightweight text-based, human-readable data interchange format for class-based object-oriented languages like Smalltalk.
MIT License
135 stars 32 forks source link

improve #stonName: comment #13

Closed jecisc closed 7 years ago

jecisc commented 8 years ago

I had a hard time with ston because I used strings in #stonName. I improved the comment.

svenvc commented 8 years ago

Maybe this is a bug, I should check out myself what happens and how it fails.

jecisc commented 8 years ago

@svenvc The mapper use #== to detect the name and it read Symbol from the file. So, if #stonName does not return a symbol there is a problem. It is in STONReader>>lookupClass:

svenvc commented 8 years ago

That should probably be changed to #= ...

svenvc commented 7 years ago

Should be fixed in https://github.com/svenvc/ston/commit/94d62c7dbc7bf6212a85ad8ac577e701f2448936

Now the following returns a string

STONTestUser3 stonName.

And you can still do

STON fromString: (STON toString: STONTestUser3 dummy).