svenvc / zinc

Zinc HTTP Components is an open-source Smalltalk framework to deal with the HTTP networking protocol.
MIT License
96 stars 56 forks source link

Sync with Pharo #112

Closed jecisc closed 1 year ago

jecisc commented 1 year ago
svenvc commented 1 year ago

Are you sure everything that you intended got included ?

testGetPharoVersion seems to fail, hence it was not removed.

jecisc commented 1 year ago

I’ve seen that but I don’t see it added in my PR. Just removed 5D916FA5-F1E8-4676-A292-0E9240357DA0

I’ll check again when I’ll be on my computer

jecisc commented 1 year ago

Could it be that Pharo8 has a failing version of the test, and since this version does not add this method anymore, it does not crush the old test?

svenvc commented 1 year ago

OK, I will merge and see what happens

svenvc commented 1 year ago

Grrrr, this is really annoying, it works on my machine (pharo 11), I will have a look later on

svenvc commented 1 year ago

I fixed it as follows: https://github.com/svenvc/zinc/commit/a77011cbf89e130495272cac46c8cda29ba4d1bf