search

sverhagen / mp3-browser

This Joomla plugin will create a table of every MP3 in a specified folder. It displays the ID3 information of each track with a link to download or play the file in the browser
https://www.totaalsoftware.com/products/mp3-browser
GNU General Public License v2.0
5 stars 6 forks source link

Column names of table and content #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.Create new folder with songs
2.See it in some Joomla article
3.

What is the expected output? What do you see instead?
I expect to see download picture in column with name Download, Size in size, 
Duration in duration ...

What version of the product are you using? On what operating system?
mp3 Browser 0.3.1 ZIP

Please provide any additional information below.

Original issue reported on code.google.com by smorsmor...@gmail.com on 11 Mar 2014 at 7:42

Attachments:

GoogleCodeExporter commented 9 years ago 
This is a known issue. It was initially discussed in issue 22. Since it is a 
recurring issue, I've added it to the wiki:

http://code.google.com/p/mp3-browser/wiki/BootstrapIssue

Original comment by sanderverh on 11 Mar 2014 at 7:49

GoogleCodeExporter commented 9 years ago 
I'm marking it as Done since I assume the given workaround will work. Please 
let me know if you need anything other.

Original comment by sanderverh on 11 Mar 2014 at 7:50

GoogleCodeExporter commented 9 years ago 
I've tried the fix in the template.css, responsive.css, and bootstrap.css file 
for my template and included a "!important"

Nothing has worked.

Joomla 3.3.3
Template = Nebula from Joomlabamboo

Original comment by tangi...@gmail.com on 4 Sep 2014 at 2:42

GoogleCodeExporter commented 9 years ago 
I also have tried the fix in template.css and it has not worked.

Joomla 3.3.3
Template = Protostar

Site is underdevelopement at 
http://www.mckeand.biz:8082/index.php/downloads/sermons

Original comment by jmckean...@gmail.com on 19 Sep 2014 at 12:03

GoogleCodeExporter commented 9 years ago 
You say "also", but what you didn't see here is that @tangierc and I 
communicated further about this and found out that it was solved with exactly 
the fix as described: https://code.google.com/p/mp3-browser/wiki/BootstrapIssue

I just looked at the URL that you gave: 
http://www.mckeand.biz:8082/index.php/downloads/sermons

Whan I apply exactly the fix as described, the problem goes away. No need even 
for "!important". I think it's just a matter of finding the right template file 
to put this in. It always is. Let me know if you can't figure it out.

Original comment by sanderverh on 19 Sep 2014 at 4:29

GoogleCodeExporter commented 9 years ago 
jmckean, sanderverh is right.  Also something that really shocked me, is that 
the fix worked making the adjustments from the Joomla backend.  I tried 
applying the fix directly to various css files directly using an FTP program 
and Textwrangler.  It didn't work for me.  Editing the template as sanderverh 
did from the Joomla backend worked like a charm.

Original comment by tangi...@gmail.com on 19 Sep 2014 at 4:34

GoogleCodeExporter commented 9 years ago 
I forgot about that distinction. Perhaps it's caching. I remember @tangierc 
telling me the caches were disabled and cleared. But I feel that Joomla's 
caches are sometimes mysterious...

Original comment by sanderverh on 19 Sep 2014 at 4:37

GoogleCodeExporter commented 9 years ago 
I added the code at the top of the template.css by going through the backend.

I followed the instructions ad on item #6 in Issue 22.

Where do I disable/clear the caches?

Original comment by jmckean...@gmail.com on 19 Sep 2014 at 2:23

GoogleCodeExporter commented 9 years ago 
I looked at Global Config -> System and Cache is disabled.

Other change I have made to the template.css from the backend apply as soon as 
I refresh my browser...

Original comment by jmckean...@gmail.com on 19 Sep 2014 at 2:25

GoogleCodeExporter commented 9 years ago 
Sorry to multipost - I keep thinking of things to say...

Original comment by jmckean...@gmail.com on 19 Sep 2014 at 3:22

Attachments:

GoogleCodeExporter commented 9 years ago 
Not all templates are created equally. If I add the CSS snippet to the top of 
Firebug, it will take more precedence (I think) than you putting it at the top 
of the CSS file. I tried it a little different, also using Firebug, but 
changing the template.css instead of the object model, and I noticed that then 
it doesn't stick until I add !important, as so:

/* fix for mp3 browser table */
.row:before, .row:after {
  content: none !important;
}

Original comment by sanderverh on 19 Sep 2014 at 3:37

GoogleCodeExporter commented 9 years ago 
Bingo - worked! !important fixed it...

Now if I can get the "Download" button to do a file save dialog instead of 
opening the mp3 in a new tab. And modify the name line to include my "Comments" 
from the mp3 between the "Title" and "Artist". I use the comment on the 
"Sermons" to include the bible verse.

Original comment by jmckean...@gmail.com on 19 Sep 2014 at 3:52

Attachments:

GoogleCodeExporter commented 9 years ago 
There is issue #38 for the download button.

You should be able to show some comments, as per this screenshot: 
https://code.google.com/p/mp3-browser/wiki/ScreenShot

Original comment by sanderverh on 19 Sep 2014 at 3:55

GoogleCodeExporter commented 9 years ago 
Sorted the comments - I also use the "subtitle" tag added the following to 
MusicItem.php:

    public function getSubtitle() {
        if (isset($this->getId3FileInfo["comments"]["subtitle"][0])) {
            return $this->getId3FileInfo["comments"]["subtitle"][0];
        } else {
            return "";
        }

also added the following to HtmlNameColumn.php in the getCellText function:

        if ($data->getSubtitle()) {
            $subtitle = $this->wrapAnchor($data, $data->getSubtitle());
            $html .= $subtitle;
        }

Take a look:

Original comment by jmckean...@gmail.com on 19 Sep 2014 at 5:37

Attachments:

GoogleCodeExporter commented 9 years ago 
Wasn't the comments thing a setting in the plugin administration?

Not sure what you did in that second snippet.

Original comment by sanderverh on 19 Sep 2014 at 6:53

GoogleCodeExporter commented 9 years ago 
No, I could not get the "Extended Info" to work to show the comments. If I turn 
on the "Extended Info" I get a blank screen.

For my purposes I also use the "subtitle" ID3 tag when I produce the MP3. I put 
the date of the recording. I know that the date is already in there, but this 
way I can guarantee the format (Month dd, yyyy). I used the ID3 tags to format 
the current site for the church. Take a look at 
http://www.fumcmexia.org/sermons.php If I could have different column for 
sermons and music I would add the album name to the sermons - I use this if the 
sermon is part of a series. 

I keep two sermons and two music mp3 around. sermon1.mp3 and music1.mp3 are the 
most recent recordings. sermon2.mp3 and music2.mp3 are the next previous 
recordings. Each week I delete the #2 recordings, rename the #1s to #2s, and 
upload new #1s.

In MusicItem.php I added the function getSubtitle because it did not exist. The 
second snippet used that function to put the "subtitle" in the cell. I also 
added the following to get my comments in the cell:

        if ($data->getComments()) {
            $comments = $this->wrapAnchor($data, $data->getComments());
            $html .= "<br/>" . $comments;
        }

So over all my getCellText function creates a cell like this:
        Subtitle
        Title (this line Bold)
        Artist
        Comments

ID3tags can hold allot of information - more than I would ever need.

Original comment by jmckean...@gmail.com on 19 Sep 2014 at 9:44

GoogleCodeExporter commented 9 years ago 
If you get a blank screen, that is a bug, and you could help out with making a 
new issue and posting the error message from the logs, thank you.

Original comment by sanderverh on 19 Sep 2014 at 11:31