sverhagen / mp3-browser

This Joomla plugin will create a table of every MP3 in a specified folder. It displays the ID3 information of each track with a link to download or play the file in the browser
https://www.totaalsoftware.com/products/mp3-browser
GNU General Public License v2.0
5 stars 5 forks source link

Link on Title doesn't work...Chinese apears also...FIXED #51

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Hover over title link
2.Click on title link

What is the expected output? What do you see instead?
Download and see source name

What version of the product are you using? On what operating system?
newest

Please provide any additional information below.
TO fix this open FTP and file located in
plugins/content/mp3browser/html/HtmlNameColumn.php
Change last lines:
 private function wrapAnchor(MusicItem $data, $textToWrap) {
        $url = $data->getUrl();
        if ($url) {
            return "<a href=\"" . $url . "\" target=\"_blank\">" . $textToWrap . "</a>";
        }
        return $textToWrap;

To This:

    private function wrapAnchor(MusicItem $data, $textToWrap) {
        $url = $data->getUrl();
        if ($url) {
            return "<a href=\"" . $data->getUrlPath() . "\" target=\"_blank\">" . $textToWrap . "</a>";
        }
        return $textToWrap;

Original issue reported on code.google.com by gojoe_go...@yahoo.com on 2 Nov 2014 at 7:19

GoogleCodeExporter commented 9 years ago
If you want it to have a mouse over title add this instead

 private function wrapAnchor(MusicItem $data, $textToWrap) {
        $url = $data->getUrl();
        if ($url) {
            return "<a href=\"" . $data->getUrlPath() . "\" title=\"Download Audio File\" target=\"_blank\">" . $textToWrap . "</a>";
        }
        return $textToWrap;

Original comment by gojoe_go...@yahoo.com on 2 Nov 2014 at 7:27

sverhagen commented 8 years ago

I can see what you're trying to do, here, but the link on the title was meant to represent the link in the MP3 information, might be a link to MP3 file -- different thing.