sverhagen / mp3-browser

This Joomla plugin will create a table of every MP3 in a specified folder. It displays the ID3 information of each track with a link to download or play the file in the browser
https://www.totaalsoftware.com/products/mp3-browser
GNU General Public License v2.0
5 stars 6 forks source link

problem with php #67

Closed frannyji closed 7 years ago

frannyji commented 8 years ago

Is the plugin going to be updated soon. My host at Siteground is not supporting php version pre 5.4. I had been testing this plugin and it was doing exactly what I wanted until a recent upgrade of php at host. Now I cannot save or use the plugin. The error message I get is:

_Deprecated: Non-static method FinderIndexer::index() should not be called statically, assuming $this from incompatible context in /home/.../public_html/plugins/finder/mp3smartsearch/mp3smartsearch.php on line 354

Fatal error: Cannot call abstract method FinderIndexer::index() in /home/.../publichtml/plugins/finder/mp3smartsearch/mp3smartsearch.php on line 354 I need to know if you can fix this. Thanks. Blessings, F

Bear4 commented 8 years ago

I like very much this plugin. It's very useful. Thanks. I want switch my site at PHP 7.0, so is there an chances to improve mp3-browser? Many thanks in anticipation for an answer.

davidascherG commented 7 years ago

Does not work with Joomla 3.6.5 and PHP 7.1. No error message. Just blank screen.

Are you planning an update to deal with this??

Jandaai commented 7 years ago

Facing the same problem, does not work with PHP7. What to do???

tdi2004 commented 7 years ago

The following worked for me (I'm using a customized version based on mp3-browser 0.3.1): I pulled mp3-browser/src/main/php/mp3browser/getid3/getid3/getid3.lib.php (42679 bytes) from github and replaced the old getid3.lib.php in /plugins/content/mp3browser/getid3/getid3 (44011 bytes). Then mp3browser worked for me under PHP 7.0 (and PHP 5.6, too) AFAICS this lib has been the only change to make it running under PHP 7.0 - if not please comment and correct me.

doctormix1978 commented 7 years ago

Thanks tdi2004. Your solution worked for me.

davidascherG commented 7 years ago

I'm no github expert and was unable to figure out how to 'pull' the getid3.lib.php file from github. I finally found gitzip at http://kinolien.github.io/gitzip/ and used that to download the entire mp3-browser/src/main/php/mp3browser/getid3/getid3/directory and replaced the file in getid2.lib.php file in /plugins/content/mp3browser/getid3/getid3.... it looks like there is really only a single line added to the new file.

On Feb 16, 2017 5:49 PM, "tdi2004" notifications@github.com wrote:

The following worked for me: I pulled mp3-browser/src/main/php/mp3browser/getid3/getid3/getid3.lib.php (42679 bytes) from github and replaced the old getid3.lib.php in /plugins/content/mp3browser/getid3/getid3 (44011 bytes). Then mp3browser worked for me under PHP 7.0 (and PHP 5.6, too) AFAICS this lib has been the only change to make it running under PHP 7.0

  • if not please comment and correct me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sverhagen/mp3-browser/issues/67#issuecomment-280488760, or mute the thread https://github.com/notifications/unsubscribe-auth/AJOtNhdBK2tVWeS1uIiEmm4tqnxyaP_Zks5rdNJ6gaJpZM4HV-F_ .

mschnye commented 7 years ago

I just tried to run my site on php 7. Although I took the getid3.lib.php, it didn't work. On frontend I get following error 0 - "Class 'getid3_lib' not found".

Can anybody help me?

Keind regards,

Marco

davidascherG commented 7 years ago

are you sure you put the new library in the right place in the directory tree??


From: mschnye [mailto:notifications@github.com] Sent: Wednesday, May 17, 2017 11:47 AM To: sverhagen/mp3-browser Cc: davidascherG; Comment Subject: Re: [sverhagen/mp3-browser] problem with php (#67)

I just tried to run my site on php 7. Although I took the getid3.lib.php, it didn't work. On frontend I get following error 0 - "Class 'getid3_lib' not found".

Can anybody help me?

Keind regards,

Marco

- You are receiving this because you commented. Reply to this email directly, view https://github.com/sverhagen/mp3-browser/issues/67#issuecomment-302133282 it on GitHub, or mute https://github.com/notifications/unsubscribe-auth/AJOtNlvmT351PrSa89dNWrRWn syE8jgyks5r6xaRgaJpZM4HV-F_ the thread. https://github.com/notifications/beacon/AJOtNrWYuAOkB_VXqxo32pmFjUU_un--ks5 r6xaRgaJpZM4HV-F_.gif

mschnye commented 7 years ago

Hi,

I Just find out, that I did a download instead of copy/paste. So there was a wrong content.

No, it works fine.

Thank you for fast responed.

Von: davidascherG [mailto:notifications@github.com] Gesendet: Mittwoch, 17. Mai 2017 21:34 An: sverhagen/mp3-browser mp3-browser@noreply.github.com Cc: mschnye marco.schnyder@2protect.ch; Comment comment@noreply.github.com Betreff: Re: [sverhagen/mp3-browser] problem with php (#67)

are you sure you put the new library in the right place in the directory tree??


From: mschnye [mailto:notifications@github.com] Sent: Wednesday, May 17, 2017 11:47 AM To: sverhagen/mp3-browser Cc: davidascherG; Comment Subject: Re: [sverhagen/mp3-browser] problem with php (#67)

I just tried to run my site on php 7. Although I took the getid3.lib.php, it didn't work. On frontend I get following error 0 - "Class 'getid3_lib' not found".

Can anybody help me?

Keind regards,

Marco

- You are receiving this because you commented. Reply to this email directly, view < https://github.com/sverhagen/mp3-browser/issues/67#issuecomment-302133282 https://github.com/sverhagen/mp3-browser/issues/67#issuecomment-302133282> it on GitHub, or mute < https://github.com/notifications/unsubscribe-auth/AJOtNlvmT351PrSa89dNWrRWn%0bsyE8jgyks5r6xaRgaJpZM4HV-F_ https://github.com/notifications/unsubscribe-auth/AJOtNlvmT351PrSa89dNWrRWn syE8jgyks5r6xaRgaJpZM4HV-F_> the thread. < https://github.com/notifications/beacon/AJOtNrWYuAOkB_VXqxo32pmFjUU_un--ks5%0br6xaRgaJpZM4HV-F_.gif https://github.com/notifications/beacon/AJOtNrWYuAOkB_VXqxo32pmFjUU_un--ks5 r6xaRgaJpZM4HV-F_.gif>

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sverhagen/mp3-browser/issues/67#issuecomment-302206957 , or mute the thread https://github.com/notifications/unsubscribe-auth/AbbZNEIaT3TBWkh4Ej66RWXz5YDlygPFks5r60uggaJpZM4HV-F_ . https://github.com/notifications/beacon/AbbZNMu7VH7_s0TcD9QLySXtjk01PuXuks5r60uggaJpZM4HV-F_.gif

sverhagen commented 7 years ago

Seems like people here describe a few different problems that mostly should have gotten fixed in cd08fe1 and e04335f. Solved in 0.4.0 (released here). Feel free to get back to me if there are remaining issues.