search

svermeulen / vim-easyclip

Simplified clipboard functionality for Vim
696 stars 21 forks source link

add `option` argument to AddWeakMapping (Closes #112) #113

Closed eloytoro closed 6 years ago

eloytoro commented 6 years ago

Alternative to #112

svermeulen commented 6 years ago

Was there a reason you didn't also make the black hole bindings buffer local? From reading the code I think that the default substitute map for s and S will no longer work when g:EasyClipUseSubstituteDefaults is set

eloytoro commented 6 years ago

no real reason, if required i can create a PR for it

eloytoro commented 6 years ago

that would make it so all of the weak mappings are set by buffer, so no parameter would be needed. Is that something you'd like?

svermeulen commented 6 years ago

Yeah I think that makes the most sense, so one more PR there would be great :)