search

svermeulen / vim-extended-ft

26 stars 4 forks source link

Conflict with tpope's flatfoot #7

Open yunake opened 8 years ago

yunake commented 8 years ago

Unfortunately, it seems if both this and tim pope's flatfoot plugins are loaded, the mappings won't register for one of them. I imagine this would be the case for space.vim too but I don't use it personally.

I'm not sure what can be done about it. Do you happen to have any ideas?

FWIW, this is one of my favourite plugins — I never understood why f motions should be limited to current line. Thank you!

svermeulen commented 8 years ago

Hey, I didn't realize anyone was actually using this plugin besides me :) I might have continued maintaining it otherwise.

I wasn't aware of flatfoot, but by coincidence, I have made a bunch of extensions to this plugin since I released it a few years ago (just for my own benefit) - including some flatfoot-like features. I'll see if I can clean it up and update this repo

svermeulen commented 8 years ago

Ok I looked into updating this plugin, but I've since made a bunch of changes that have made it quite different from how vim-extended-ft works. So I've pushed all the changes I've made to it as a new plugin here:

https://github.com/svermeulen/vim-NotableFt

Which means that I won't be maintaining this plugin anymore. If you want though, you can check out vim-NotableFt and pull back some of the fixes into this repo. I've given you push access to vim-extended-ft, so if you want to maintain it, you are welcome :)

yunake commented 8 years ago

Thanks. vimscript is not my forte, but i'll make any improvements i can. i now watch this repo so i assume i'll be getting notifications if any new issues/pull requests are created? are there any particular changes in NotableFt that you think i should look into backporting? finally, do you think you will have time to do reviews for me, at least in the first couple of changes? it's okay if you don't.

I've poked around your new plugin and while i think it's neat, i feel it's a bit too much of a departure from barebones f/t commands for me. i think i'll stick with this plugin and create my own set of flatfoot-like motions that do not use f and t keys.

svermeulen commented 8 years ago

I can't remember exactly what fixes there are - what I would recommend doing is to run a diff against both and see if you can spot any useful changes

Sure, I can help review vimscript