Hi there, I've not opened a new issue for this because it's essentially the same as the closed issue #104 - let me know if you'd like me to create a new issue for this PR.
To recap #104, currently the link tag doesn't work for paginated pages that aren't in the root directory. This is because when the paginated page is copied, page.dir isn't set. Then page.relative_path (which is what the link tag looks for) is in turn set by joining dir and name.
In this PR, I'm setting @dir in the set_url method after @url is set because I'm using the inherited dir method from the Jekyll Page class which uses the url to get dir.
I'm aware that this change means the set_url method doesn't just set the url. There are a few options:
rename the method to something like set_url_dir
create a new PaginationPage method called set_dir to be called after set_url is called in paginationModel.rb, or
Hi there, I've not opened a new issue for this because it's essentially the same as the closed issue #104 - let me know if you'd like me to create a new issue for this PR.
To recap #104, currently the
linktag doesn't work for paginated pages that aren't in the root directory. This is because when the paginated page is copied,page.dirisn't set. Thenpage.relative_path(which is what thelinktag looks for) is in turn set by joining dir and name.In this PR, I'm setting
@dirin theset_urlmethod after@urlis set because I'm using the inheriteddirmethod from the JekyllPageclass which uses the url to get dir.I'm aware that this change means the
set_urlmethod doesn't just set the url. There are a few options:set_url_dirPaginationPagemethod calledset_dirto be called afterset_urlis called inpaginationModel.rb, or