refactor(wrap-stream-in-html): makes the wrapper easier to maintain - Githubissues

sverweij / dependency-cruiser

Validate and visualize dependencies. Your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.

https://npmjs.com/dependency-cruiser

MIT License

5.33k stars 251 forks source link

refactor(wrap-stream-in-html): makes the wrapper easier to maintain #877

Closed sverweij closed 11 months ago

sverweij commented 11 months ago

Description

inline the html into javascript
move the css to a separate file so styling tweaks are easier to get to

Motivation and Context

Editors kept autocorrecting 'header' and 'footer' html with closing and opening tags that made the result invalid html
The css is now easier to get to

How Has This Been Tested?

[x] green ci

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation only change
[x] Refactor (non-breaking change which fixes an issue without changing functionality)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] :book:
- My change doesn't require a documentation update, or ...
- it does and I have updated it
[x] :balance_scale:
- The contribution will be subject to The MIT license, and I'm OK with that.
- The contribution is my own original work.
- I am ok with the stuff in CONTRIBUTING.md.

codeclimate[bot] commented 11 months ago

Code Climate has analyzed commit 8988d619 and detected 0 issues on this pull request.

View more on Code Climate.