refactor(init-config): makes stderr, stdout configurable - so we can easier test their uses - Githubissues

sverweij / dependency-cruiser

Validate and visualize dependencies. Your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.

https://npmjs.com/dependency-cruiser

MIT License

5.16k stars 249 forks source link

refactor(init-config): makes stderr, stdout configurable - so we can easier test their uses #897

Closed sverweij closed 8 months ago

sverweij commented 8 months ago

Description

adds out & err stream parameters to the init config
updates tests so they test for what is written to them

Motivation and Context

More reliable tests
Less stdout/ stderr poluting the standard test report

How Has This Been Tested?

[x] green ci
[x] adapted automated non-regression tests

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation only change
[x] Refactor (non-breaking change which fixes an issue without changing functionality)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] :book:
- My change doesn't require a documentation update, or ...
- it does and I have updated it
[x] :balance_scale:
- The contribution will be subject to The MIT license, and I'm OK with that.
- The contribution is my own original work.
- I am ok with the stuff in CONTRIBUTING.md.

codeclimate[bot] commented 8 months ago

Code Climate has analyzed commit b42c989c and detected 0 issues on this pull request.

View more on Code Climate.