fix(resolve): makes dependency classifier handle more flavours of the 'workspaces' type alias field - Githubissues

sverweij / dependency-cruiser

Validate and visualize dependencies. Your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.

https://npmjs.com/dependency-cruiser

MIT License

5.27k stars 250 forks source link

fix(resolve): makes dependency classifier handle more flavours of the 'workspaces' type alias field #920

Closed sverweij closed 7 months ago

sverweij commented 7 months ago

Description

ignores 'workspaces' field when it isn't an array and it doesn't contain a yarn1 workspaces.packages field
also classifies dependencies resolving via yarn1 workspaces.packages fields as aliased, aliased-workspace

Motivation and Context

fixes #919

How Has This Been Tested?

[x] green ci
[x] additional automated non-regression test

Note: a version with this fix has been published as dependency-cruiser@16.2.4-beta-1 - once the PR is merged it'll be part of dependency-cruiser@16.2.4.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation only change
[ ] Refactor (non-breaking change which fixes an issue without changing functionality)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] :book:
- My change doesn't require a documentation update, or ...
- it does and I have updated it
[x] :balance_scale:
- The contribution will be subject to The MIT license, and I'm OK with that.
- The contribution is my own original work.
- I am ok with the stuff in CONTRIBUTING.md.

codeclimate[bot] commented 7 months ago

Code Climate has analyzed commit 717ef45d and detected 0 issues on this pull request.

View more on Code Climate.