refactor: removes 3rd party dependency 'indent-string' - Githubissues

sverweij / dependency-cruiser

Validate and visualize dependencies. Your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.

https://npmjs.com/dependency-cruiser

MIT License

5.27k stars 250 forks source link

refactor: removes 3rd party dependency 'indent-string' #940

Closed sverweij closed 4 months ago

sverweij commented 4 months ago

Description

removes 3rd party dependency 'indent-string'
replaces it with the simple string replace it ultimately comes down to (regex shamelessly copied from the indent-string package).

Motivation and Context

Less dependencies => less maintenance overhead. Moreover, the part of indent-string we actually use is so trivial it's simpler to pull it in.

How Has This Been Tested?

[x] green ci

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation only change
[x] Refactor (non-breaking change which fixes an issue without changing functionality)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] :book:
- My change doesn't require a documentation update, or ...
- it does and I have updated it
[x] :balance_scale:
- The contribution will be subject to The MIT license, and I'm OK with that.
- The contribution is my own original work.
- I am ok with the stuff in CONTRIBUTING.md.

socket-security[bot] commented 4 months ago

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/indent-string@5.0.0

View full report↗︎

codeclimate[bot] commented 4 months ago

Code Climate has analyzed commit 19d85380 and detected 0 issues on this pull request.

View more on Code Climate.