Closed ferdynator closed 2 months ago
Code Climate has analyzed commit 6c43fa4b and detected 0 issues on this pull request.
View more on Code Climate.
Hi @ferdynator thanks for this fix! I totally missed this was possible in vue2.
Code modification is clear & great to see additional unit tests to prevent regression
=> LGTM
Hi @ferdynator (and @timleers) - when you're reading this dependency-cruiser@16.3.5, which includes this fix, is published on npmjs.
Thanks again for the well-documented and executed PR!
Thank you for merging it so quickly. I can confirm that the new version fixes our issue.
Description
Currently the vue2 template compiler only extracts content from the
script
section of single file components. Script setup SFCs are supported since version 2.17. This MR updates the implementation analogous to the vue 3@vue/compiler-sfc
to extract content from<setup script>
components in case they existMotivation and Context
Without this change Vue 2 components using
<script setup>
appear empty to dependency cruiser leading to missing imports.How Has This Been Tested?
Types of changes
Checklist