refactor: replaces chalk with picocolors - Githubissues

sverweij / dependency-cruiser

Validate and visualize dependencies. Your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.

https://npmjs.com/dependency-cruiser

MIT License

5.15k stars 249 forks source link

refactor: replaces chalk with picocolors #945

Closed sverweij closed 2 months ago

sverweij commented 2 months ago

Description

replaces chalk with picocolors
test: removes chalk setup & tear down code in before & after triggers in lieu of setting the NO_COLOR environment variable

Motivation and Context

picocolors is ~ 1/3 of the size of even chalk5 (chalk: 5.4kb/2.3kb zipped/ 44kb install vs picocolors: 1.7kb/0.7kb zipped/ 5.2kb install) which better for both loading times & download times/ footprint.
picocolors suports NO_COLOR which is helpful for dependency-cruiser's A11Y
(from the department of due diligence: picocolors has a sizeable download count, several major packages use it, it has recent updates (2 months ago vs 1y ago on chalk))

How Has This Been Tested?

[x] green ci

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation only change
[x] Refactor (non-breaking change which fixes an issue without changing functionality)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] :book:
- My change doesn't require a documentation update, or ...
- it does and I have updated it
[x] :balance_scale:
- The contribution will be subject to The MIT license, and I'm OK with that.
- The contribution is my own original work.
- I am ok with the stuff in CONTRIBUTING.md.

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit d7c481a3 and detected 0 issues on this pull request.

View more on Code Climate.