sverweij / mscgen_js

text => sequence charts
https://mscgen.js.org
GNU General Public License v3.0
206 stars 25 forks source link

More arcskip wildness #251

Closed 2pl closed 6 years ago

2pl commented 6 years ago

@sverweij following up on #250, I found a few more cases of arcskip wildness / oddities.

msc {
  hscale="0.8",
  arcgradient=0,
  wordwraparcs=true;

  kfk1 [label="Kafka", linecolor="#859900", textcolor="white", textbgcolor="#859900", arclinecolor="#859900", arctextcolor="#859900"],
  iabuild [label="IA builder", linecolor="#cb4b16", textcolor="white", textbgcolor="#cb4b16", arclinecolor="#cb4b16", arctextcolor="#cb4b16"],
  kfk2 [label="Kafka", linecolor="#859900", textcolor="white", textbgcolor="#859900", arclinecolor="#859900", arctextcolor="#859900"],
  k2db [label="KFK 2 DB", linecolor="#dc322f", textcolor="white", textbgcolor="#dc322f", arclinecolor="#dc322f", arctextcolor="#dc322f"],
  mysql [label="MySQL", linecolor="#d33682", textcolor="white", textbgcolor="#d33682", arclinecolor="#d33682", arctextcolor="#d33682"];

--- [label="no arcskip, same line is not what I want but I understand the logic here", linecolor="grey", textbgcolor="white", textcolor="black"];

  kfk1 >> iabuild,

    iabuild loop mysql [label="for each {Bid, Ask}"]{
    iabuild => kfk2 [label="IA-Quote"],
    kfk2 >> k2db [label="", arcskip=1];

    k2db => mysql [label="INSERT in Orders"],
    k2db => mysql [label="\nINSERT in OrderLife", arcskip=1];
    |||;
  };

--- [label="arcskip = 1, next line is closer to what I really want", linecolor="grey", textbgcolor="white", textcolor="black"];
  kfk1 >> iabuild[arcskip=1];

  iabuild loop mysql [label="for each {Bid, Ask}"]{
    iabuild => kfk2 [label="IA-Quote"],
    kfk2 >> k2db [label="", arcskip=1];

    k2db => mysql [label="INSERT in Orders"],
    k2db => mysql [label="\nINSERT in OrderLife", arcskip=1];
    |||;
  };

--- [label="arcskip = 0, same line goes wild", linecolor="grey", textbgcolor="white", textcolor="black"];
  kfk1 >> iabuild[arcskip=0],

    iabuild loop mysql [label="for each {Bid, Ask}"]{
    iabuild => kfk2 [label="IA-Quote"],
    kfk2 >> k2db [label="", arcskip=1];

    k2db => mysql [label="INSERT in Orders"],
    k2db => mysql [label="\nINSERT in OrderLife", arcskip=1];
    |||;
  };

}
screen shot 2017-12-12 at 08 43 34
sverweij commented 6 years ago

Wow, impressive catch!

I've fixed it, but need some time (~1h) to release it on all channels.

This how it now looks on my machine: betteriguess

sverweij commented 6 years ago

@2pl I've published the new version - let me know if it fixes the issue on your side as well

2pl commented 6 years ago

Works for me as well. @sverweij thank you for fixing this, you are getting too fast for me, will stop reporting bugs and start posting feature requests ;-)