refactor: replaces lodash functions where a good native alternative exists - Githubissues

sverweij / state-machine-cat

write beautiful state charts :scream_cat:

https://state-machine-cat.js.org

MIT License

793 stars 45 forks source link

refactor: replaces lodash functions where a good native alternative exists #196

Closed sverweij closed 11 months ago

sverweij commented 11 months ago

Description

replaces instances of castArray, reject and has with (just as straightforward) native variants
replaces cloneDeep with the json hack. When nodejs 16 stops being supported we can switch it to structuredClone.

Motivation and Context

less dependencies === less pain

How Has This Been Tested?

[x] green ci

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation only change
[x] Refactor (non-breaking change which fixes an issue without changing functionality)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] :book:
- My change doesn't require a documentation update, or ...
- it does and I have updated it
[x] :balance_scale:
- The contribution will be subject to The MIT license, and I'm OK with that.
- The contribution is my own original work.
- I am ok with the stuff in CONTRIBUTING.md.

codeclimate[bot] commented 11 months ago

Code Climate has analyzed commit 331ed7ec and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.