search

svetlyak40wt / dotfiler

Shell agnostic git based dotfiles package manager, written in Python.
238 stars 31 forks source link

dotfiler ignores .gitignore_global #9

Closed drzel closed 9 years ago

drzel commented 9 years ago

This is a dotfile that I'd like to include in my dotfile repo, but it's ignored for some reason..

svetlyak40wt commented 9 years ago

Probably, that is because .gitignore is ignored in this code: https://github.com/drzel/dotfiler/blob/35b2b74a9126520dff6fd9e6f4088c112bc33f96/bin/lib/dot/core.py#L139

Try to remove .gitignore temprorary and see if it will help. If it is, then we'll think how to workaround this problem.

drzel commented 9 years ago

I've removed the .gitignore but the issue persists. I don't really know python but I can't understand from your code why ignoring .gitignore would also ignore .gitignore_global... Date: Thu, 27 Aug 2015 05:15:57 -0700 From: notifications@github.com To: dotfiler@noreply.github.com CC: shayolden@hotmail.com Subject: Re: [dotfiler] dotfiler ignores .gitignore_global (#9)

Probably, that is because .gitignore is ignored in this code: https://github.com/drzel/dotfiler/blob/35b2b74a9126520dff6fd9e6f4088c112bc33f96/bin/lib/dot/core.py#L139

Try to remove .gitignore temprorary and see if it will help. If it is, then we'll think how to workaround this problem.

— Reply to this email directly or view it on GitHub.

jawshooah commented 9 years ago

I can't understand from your code why ignoring .gitignore would also ignore .gitignore_global

Because the string .gitignore_global contains a match for the regex.

>>> regex = re.compile('.gitignore')
>>> regex.match('.gitignore_global')
<_sre.SRE_Match object at 0x10b66c4a8>
drzel commented 9 years ago

Pull request submitted. (:

Date: Thu, 27 Aug 2015 21:17:20 -0700 From: notifications@github.com To: dotfiler@noreply.github.com CC: shayolden@hotmail.com Subject: Re: [dotfiler] dotfiler ignores .gitignore_global (#9)

I can't understand from your code why ignoring .gitignore would also ignore .gitignore_global

Because the string .gitignore_global contains a match for the regex.

regex = re.compile('.gitignore') regex.match('.gitignore_global') <_sre.SRE_Match object at 0x10b66c4a8>

— Reply to this email directly or view it on GitHub.

svetlyak40wt commented 9 years ago

Pull request was merged. Thank you, guys!