svewap / ws_flexslider

Flexslider extension for TYPO3
7 stars 19 forks source link

Bug: Language is not respected #31

Open vistainteractive opened 6 years ago

vistainteractive commented 6 years ago

When we added a localization, the slider was showing images from both languages.

Setting $query->getQuerySettings()->setRespectSysLanguage(true) in the createQuery() in class ImageRepository seems to resolve this.

public function createQuery() { $query = parent::createQuery(); $query->getQuerySettings()->setRespectStoragePage(false); $query->getQuerySettings()->setRespectSysLanguage(true); return $query; }

froemken commented 6 years ago

If you translate the content element with ws_flexslider plugin, please keep the FlexSlider images as they are. Do not delete them. Else the relations to default language will be broken. Please only change the Image itself within the Flexslider image record. While keeping the flexslider images you will see two radio boxes below each image: use custom and use value from default language. If you want to change an image, please switch that value to: use custom. Because of an extbase translation bug you should install extension repair_translation 1.4.0.

Now you should see the images in correct language.

Stefan

froemken commented 6 years ago

If this workflow works for you, please confirm that here in that ticket. Maybe one of the contributers can add that workflow to their documentation, as I can see some more translation related issues here in github.

Stefan