Replace through2 with smaller Transform helper

svg-sprite / gulp-svg-sprite

SVG sprites & stacks galore — Gulp plugin wrapping around svg-sprite that reads in a bunch of SVG files, optimizes them and creates SVG sprites and CSS resources in various flavours

MIT License

648 stars 43 forks source link

Replace through2 with smaller Transform helper #118

Closed mxmason closed 2 years ago

mxmason commented 3 years ago

Hi there! An NPM audit warning pointed me to this repo today. Glad to see it's getting active development!

This PR is just to make the module a little lighter!

through2 is overkill for what this code is doing
we store a reference to Object.prototype.hasOwnProperty for easier lookup

XhmikosR commented 2 years ago

Hey, thanks for the PR.

I'm not sure I like the second patch. As for the first one, we could just alternatively depend on the transfob package but I also hate dependencies.

Anyway, I think we could land the first patch.

PS. I updated this package but I'm still stuck upstream. If you have time to help out with getting svg-sprite v2.0.0 out let me know.

XhmikosR commented 2 years ago

Cheers, thanks!