search

svg-sprite / gulp-svg-sprite

SVG sprites & stacks galore — Gulp plugin wrapping around svg-sprite that reads in a bunch of SVG files, optimizes them and creates SVG sprites and CSS resources in various flavours
MIT License
648 stars 43 forks source link

SonarCloud is complaining about security hotspot in icons.html #129

Closed banoodle closed 2 years ago

banoodle commented 2 years ago

We just started using sonarcloud to run static code tests on our git commits.

It is complaining that the hyperlink inside the generated icons.html lacks a rel=noopener attribute which it considers a security hotspot.

Could this attribute be added to the next release? I notice this has been fixed in the svg-sprite repo.

Screen Shot 2022-06-01 at 2 04 16 PM

Kreeg commented 2 years ago

Hi! This is already fixed in svg-sprite package. And will be fixed here in the next release this month.