Fix improperly configured error showing

svg-sprite / gulp-svg-sprite

SVG sprites & stacks galore — Gulp plugin wrapping around svg-sprite that reads in a bunch of SVG files, optimizes them and creates SVG sprites and CSS resources in various flavours

MIT License

648 stars 43 forks source link

Fix improperly configured error showing #136

Closed Kreeg closed 1 year ago

Kreeg commented 1 year ago

Fixes #82

XhmikosR commented 1 year ago

I assume you tested it, @Kreeg, right? I don't really use gulp or grunt a lot nowadays :)

I can make a new release after this is merged.

Kreeg commented 1 year ago

I changed svg-sprite package's file to throw errors and it seems to do well There is some refactoring ahead in the main package. Sometime we throw formatted error like

 error = util.format('SVGSpriter.add: "%s" is not the local part of "%s"', name, file);

Sometimes we rely on winston logger, like

spriter.error('Optimizing "%s" with SVGO failed with error "%s"', shape.name, error);

I think these should be unified

XhmikosR commented 1 year ago

Your call, but I agree we should be consistent. BTW, if we could replace winston with something smaller that has the same features we currently use that would make more sense.

Kreeg commented 1 year ago

@XhmikosR hello. I think we're ready for new release.