peerDependencies - Githubissues

svg-sprite / gulp-svg-sprite

SVG sprites & stacks galore — Gulp plugin wrapping around svg-sprite that reads in a bunch of SVG files, optimizes them and creates SVG sprites and CSS resources in various flavours

MIT License

647 stars 43 forks source link

peerDependencies #25

Closed guyellis closed 9 years ago

guyellis commented 9 years ago

npm WARN peerDependencies The peer dependency vinyl@^0.4.6 included from gulp-svg-sprite will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.

jkphl commented 9 years ago

Hi @guyellis,

thanks for reporting this. Do I understand this right that all I need to "fix" this is list vinyl as a regular dependency? (Guess this holds true for all peerDependencies in the future?)

Cheers, Joschi

guyellis commented 9 years ago

@jkphl Yes - I believe that's the case.

shaneparsons commented 9 years ago

Until there's a fix, what do I have to do from my end to be able to use gulp-svg-sprite?

jkphl commented 9 years ago

@shaneparsons Two things:

The "fix" is already commited to this repo. If you want to, just replace your package.json with the most recent one in this repo.
As far as I understood, all this is just a warning about the future deprecation of a feature in npm@3. It should not be a show-stopper of any kind. There is no urgent need to do anything.

However, I will try to push out new releases soon, so you might also just wait and update later today.

shaneparsons commented 9 years ago

ah okay good to know, thanks for clearing that up!

jkphl commented 9 years ago

Fixed as of release v1.2.4.