search

svga / SVGAPlayer-Web

Similar to Lottie. Render After Effects / Animate CC (Flash) animations natively on Android and iOS, Web. 使用 SVGAPlayer 在 Android、iOS、Web中播放 After Effects / Animate CC (Flash) 动画。
https://svga.io
Apache License 2.0
954 stars 239 forks source link

Typo in renderer's path command validtion? #148

Closed Naeemo closed 3 years ago

Naeemo commented 3 years ago

src/Canvas/renderer.js uses validMethods to filter out unknown path commands. Notice both R and r are in there, which probably should be A and a for elliptical arc curve.

https://github.com/svga/SVGAPlayer-Web/blob/de4af292b04565a9817725a7b4361ea16e2f3dbe/src/Canvas/renderer.js#L5

https://github.com/svga/SVGAPlayer-Web/blob/de4af292b04565a9817725a7b4361ea16e2f3dbe/src/Canvas/renderer.js#L308-L311

https://github.com/svga/SVGAPlayer-Web/blob/de4af292b04565a9817725a7b4361ea16e2f3dbe/src/Canvas/renderer.js#L426-L429

Naeemo commented 3 years ago

This is harmless however, both the two commands are not rendered by the renderer.

PonyCui commented 3 years ago

emm, yes.