search

svgdotjs / svg.draw.js

An extension of svg.js which allows to draw elements with mouse
MIT License
239 stars 57 forks source link

Added `drawCircles` option for polygon/lines points #61

Closed johnner closed 4 years ago

johnner commented 4 years ago

Fix for the issue #59: added a drawCircles option to control the render for the small circles around polyline/line points.

ericcarino commented 4 years ago

@Fuzzyma can you please merge this PR?

Fuzzyma commented 4 years ago

Do you by any chance know each other or why is this pr getting a comment at the same day its created? :D

ericcarino commented 4 years ago

Do you by any chance know each other or why is this pr getting a comment at the same day its created? :D

Yes, we know each other. :)

Fuzzyma commented 4 years ago

Just for your information: This plugin is pretty old and doesnt work with svg.js v3. So you might run your own code instead until a new version is released :). Also: v3 is awesome!

johnner commented 4 years ago

@Fuzzyma sorry, looks like I forgot to update dist directory with the build for this change. Can you please merge this one too: https://github.com/svgdotjs/svg.draw.js/pull/62?