search

svgdotjs / svg.js

The lightweight library for manipulating and animating SVG
https://svgjs.dev
Other
11.14k stars 1.08k forks source link

We might want to reduce the type property #1078

Closed Fuzzyma closed 1 year ago

Fuzzyma commented 4 years ago

Just profiled an application and even though the impact of this particular change isnt a big issue, its still notable. We have a line in Dom.js which is just this.type = node.nodeName. How often do we use this.type in our code? Maybe it would be sensible to replace the occurence with this.node.nodeName instead.

Fuzzyma commented 4 years ago

its exactly used ONCE