search

svgdotjs / svg.js

The lightweight library for manipulating and animating SVG
https://svgjs.dev
Other
11.01k stars 1.07k forks source link

typos #1179

Closed ordago closed 3 years ago

ordago commented 3 years ago

All the changes are in either comments or test messages.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 99.889% when pulling 7ca6777666083cb6da424796117d1d05f3ea4519 on ordago:1178-typos into c01bead5556cedea7dff8d4965bd70070b018c6f on svgdotjs:master.

Fuzzyma commented 3 years ago

Oh wow! Did you use software or did you really do this one by one? :D

ordago commented 3 years ago

Hi @Fuzzyma I used Phpstorm, and then went over the results manually since the names of variables, constants... give a lot of false positives.

I also saw these but didn't touch it because it was in code:

https://github.com/svgdotjs/svg.js/blob/4f4dc2afa62cb899a5cae72c359150f8adf27edb/spec/spec/modules/optional/sugar.js#L28

https://github.com/svgdotjs/svg.js/blob/4f4dc2afa62cb899a5cae72c359150f8adf27edb/spec/spec/modules/optional/sugar.js#L82

These should be fixtures instead of fictures, right?

Fuzzyma commented 3 years ago

@ordago wow, thanks! Yes, it should be fixtures. For the test, it doesn't really matter but ofc it would be better to be correct rather then wrong :D