svgdotjs / svg.js

The lightweight library for manipulating and animating SVG
https://svgjs.dev
Other
11.01k stars 1.07k forks source link

TypeScript typings out of date but fixed in commit from 2019 - can we get a new release? #1199

Closed LaXiS96 closed 3 years ago

LaXiS96 commented 3 years ago

Hello, I was trying to get this snippet of code working in my project (TypeScript 4.2.4 and @svgdotjs/svg.js@3.0.16):

var timeline = new SVG.Timeline()

var rect1 = draw.rect(100, 200)
var rect2 = draw.rect(200, 100)

rect1.timeline(timeline)
rect2.timeline(timeline)

rect1.animate(300, 0, 'absolute').move(300, 300) // start at time 0 of timeline
rect2.animate(400, 200, 'absolute').move(500, 500) // start at time 200 of timeline

(taken from https://svgjs.com/docs/3.0/animating/#orchestrate-animations)

VSCode kept complaining that the documented usage of Element.animate(...) was incompatible with the included svg.js.d.ts typing. I noticed that the particular issue was fixed in commit be7ae4c2f6077af9363a266e59eba36dbface813, which is from December 2019.

Is there any particular reason why a new version hasn't yet been released, to include this and hopefully more fixes?

Thank you for your work, this library is awesome!

vladdeSV commented 3 years ago

This is an issue for me as well, but with #1015.

I would very much appreciate a new release as well.

Shiuyin commented 3 years ago

We very much need a new release as well. ForeignObject is missing typings which has been fixed a long time ago, without creating a new version.

keyone2693z commented 3 years ago

ForeignObject is missing typings

Fuzzyma commented 3 years ago

finally out

vladdeSV commented 3 years ago

Thank you so much! 🎉