search

svgdotjs / svg.js

The lightweight library for manipulating and animating SVG
https://svgjs.dev
Other
11.07k stars 1.08k forks source link

node or new #1219

Closed visionm45 closed 3 years ago

visionm45 commented 3 years ago

edit nodeornew in order to behave consistently across different contexts.

note. npm automatically updated the package lock file and I pushed it without realizing so it would probably not be desired to merge that.

Fuzzyma commented 3 years ago

just reset the package lock to the old state and commit it again :)

visionm45 commented 3 years ago

I'm a bit new to using git so sorry if some of the things that I did seem a bit strange. Anyway I think that now the only difference in this branch is in the function nodeOrNew

Fuzzyma commented 3 years ago

No problem. I can just squash everything into one commit so nobody sees all the commits