svgdotjs / svg.js

The lightweight library for manipulating and animating SVG

https://svgjs.dev

Other

11.07k stars 1.08k forks source link

EventTarget.off is missing argument options #1248

Closed Mscht closed 2 years ago

Mscht commented 2 years ago

Bug report

EventTarget.off is missing argument options. So it is not possible to unbind an event handler that uses the options when calling EventTarget.on. Workaround: Using the top level function off().

Also note: the interface of the top level method off() is missing the argument options

Fiddle

https://jsfiddle.net/swd4h7g5/

Explanation

EventTarget.off should pass options to top level function off()
Behaviour should be se same like using the top level function off() directly
Please add argument options to function off in svg.js.d.ts.

Fuzzyma commented 2 years ago

Feel free to create a PR to fix this issue :)