search

svgdotjs / svg.js

The lightweight library for manipulating and animating SVG
https://svgjs.dev
Other
10.95k stars 1.07k forks source link

1277: remove double quotes from maskWith url() #1278

Closed HarryFaulkner closed 1 year ago

HarryFaulkner commented 1 year ago

https://github.com/svgdotjs/svg.js/issues/1277

Fuzzyma commented 1 year ago

We have multiple spots with the same Syntax in svg.js. If we change it, we should change it anywhere. e. G. Clip-path.

Also: it seems like you removed the quote all together. Wouldn't it be better to replace it with a single quote instead?

HarryFaulkner commented 1 year ago

We have multiple spots with the same Syntax in svg.js. If we change it, we should change it anywhere. e. G. Clip-path.

Also: it seems like you removed the quote all together. Wouldn't it be better to replace it with a single quote instead?

Change it everywhere Sure, will add it in the other areas also.

Replace quote with single quote This is the syntax used by the official documentation, note that there are no inner quotes <circle cx="50" cy="50" r="50" mask="url(#myMask)" /> https://developer.mozilla.org/en-US/docs/Web/SVG/Element/mask

HarryFaulkner commented 1 year ago

Any chance of this getting merged?

rossburton commented 1 year ago

This is breaking my SVGs that I want to load into Affinity, so yeah merge please :)

Fuzzyma commented 1 year ago

sorry for the long wait. my bad!