Closed iola1999 closed 2 weeks ago
@iola1999 did you encounter an actual problem? Because I tested this and it worked fine. In case I am talking to a bot: shame on you
@Fuzzyma
Hi, here is reproduce: https://github.com/iola1999/debug-0618-svgjs/tree/main
In case I am talking to a bot: shame on you
No, I am not a native English speaker, I just don't want to spend too much time on the wording.
After modify the order, the build works fine:
What a weird bug in "father". I feel like they should fix it. Its not hard to just load the default key lol. I released a new version that fixes it. Sorry for not merging. I just fixed it locally
Also, these descriptions can be found in the Node.js documentation:
"default" - the generic fallback that always matches. Can be a CommonJS or ES module file. This condition should always come last.
This PR addresses an issue with the
package.json
where thedefault
export condition was not listed as the final entry in theexports
field. While the ECMAScript specification indicates that object keys are unordered, some build tools have come to rely on the order of export conditions to function correctly. By moving thedefault
condition to the last position, we can improve the compatibility of this package with a wider variety of build tools and environments that may depend on this ordering.Changes made:
default
export condition within the.exports
field ofpackage.json
to appear last for bothimport
andrequire
conditions.Benefits:
exports
field.package.json
.Please review the changes and merge this PR if everything is in order. Thank you for considering this improvement to the package's build tool compatibility.