search

svgdotjs / svg.resize.js

An extension of svg.js which allows to resize elements which are selected
MIT License
92 stars 67 forks source link

Add option saveAspectRatio #43

Closed clusterberries closed 6 years ago

clusterberries commented 6 years ago

This PR should close or partially close #10 If saveAspectRatio is true, then element saves its aspect ratio while resizing with lt, rt, rb or lb points. Points t, b, l, r are not affected.

Fuzzyma commented 6 years ago

Wow nice work! Did you forgot a var in frot of the snap variable? Looks pretty global to me now...

clusterberries commented 6 years ago

No, snap is defined earlier var snap = this.snapToGrid(diffX, diffY); then we call snap = this.checkAspectRatio(snap);

Fuzzyma commented 6 years ago

Alright. Searched for it and overlooked it :D. Well I guess we can merge it then, right? :)

clusterberries commented 6 years ago

@Fuzzyma yes, thanks! I've tested this changes with such elements as rectangle, ellipse, image. If there are something more to check, I can do it.

clusterberries commented 6 years ago

Hi @Fuzzyma ! Could you please create a build of the library with this changes? I'm using files from dist folder, but it doesn't contain this PR. Thanks!

Fuzzyma commented 6 years ago

released in a new version^^