Correctly calculate an arc's centre point

svgdotjs / svgdom

Straightforward DOM implementation to make SVG.js run headless on Node.js

MIT License

274 stars 54 forks source link

Correctly calculate an arc's centre point #36

Closed dbrnz closed 5 years ago

dbrnz commented 5 years ago

This fixes #35.

Fuzzyma commented 5 years ago

Really? It was a missing this?? Did I miss something or is that the whole solution? :D

dbrnz commented 5 years ago

Yes, that was all! Otherwise this comparison for the new Arc() constructors called from splitAt() were comparing a boolean and an integer. This will always be false.

Fuzzyma commented 5 years ago

That means you were completely right when you pointed out your guess about the one commit which broke it - because we converted those variables :D

dbrnz commented 5 years ago

Intuition and many decades of debugging software :-)

Fuzzyma commented 5 years ago

Jeah I guess :D. I will merge that when iam home! Thank you very much!