search

svgdotjs / svgdotjs.github.io

Documentation and website for SVG.js
http://svgjs.dev
Other
13 stars 23 forks source link

Document scale()'s center #83

Closed edemaine closed 4 years ago

edemaine commented 4 years ago

Fix #1062 by documenting scale()'s default center and how to override.

source branch version of #81, as requested

edemaine commented 4 years ago

I did finally get this to install, and I can build a static folder (from source branch) and a 3.0 folder (from source-3.0 branch). But I'm not quite sure how to turn those into a PR against master -- does static generate the root directory or docs/2.7 (neither seemed like a good match)? I assume 3.0 replaces docs/3.0...

Fuzzyma commented 4 years ago

Basically you build the static version with php statify.php and you keep the generated 3.0 folder and put it in the maste branch under docs/$version. Not sure if that was a good explanation, though :D

edemaine commented 4 years ago

@Fuzzyma I tried that. However, the source branch doesn't seem to generate the right content for docs/2.7. For example, it produces a diff like this:

--- a/docs/2.7/404.html
+++ b/docs/2.7/404.html
@@ -2,30 +2,29 @@
 <!DOCTYPE html>
 <html lang="en">
   <head>
+
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta charset="utf-8">
-    <title>SVG.js v2.7 | Not found!</title>
+    <title>SVG.js | Not found!</title>
     <meta name="description" content="Oops! Page could not be found. We're sorr
y, this is not the page you are looking for. But don't worry, just try the searc
h function on the left.">
     <meta name="twitter:card" content="summary" />
     <meta name="twitter:site" content="@svg_js" />
     <meta name="twitter:creator" content="@svg_js" />
-    <meta property="og:url" content="https://svgjs.com/docs/2.7/404" />
+    <meta property="og:url" content="https://svgjs.com/404" />
     <meta property="og:title" content="Not found!" />
     <meta property="og:description" content="Oops! Page could not be found. We'
re sorry, this is not the page you are looking for. But don't worry, just try th
e search function on the left." />
-    <meta property="og:image" content="https://svgjs.com/docs/2.7/assets/images
/logo-svg-js-01d.png" />
-
-    <meta name="docsearch:version" content="2.7">
+    <meta property="og:image" content="https://svgjs.com/assets/images/logo-svg
-js-01d.png" />

Should I try the source-2.7 branch instead? (The source-3.0 branch doesn't have this problem.)

Fuzzyma commented 4 years ago

Yes you can try that. Sorry for the inconvinience. I am on the go to Australia for half a year. So I am a bit off the record here